[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DDCLDNFBCALB.19TNBLSQJ5X86@linaro.org>
Date: Wed, 08 Oct 2025 03:40:42 +0100
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Krzysztof Kozlowski" <krzk@...nel.org>, "Srinivas Kandagatla"
<srini@...nel.org>, "Liam Girdwood" <lgirdwood@...il.com>, "Mark Brown"
<broonie@...nel.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof
Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>
Cc: "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@....qualcomm.com>,
<linux-sound@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and
RB1 soundcards
On Tue Oct 7, 2025 at 2:45 AM BST, Krzysztof Kozlowski wrote:
> On 07/10/2025 10:26, Alexey Klimov wrote:
>> Add soundcard compatible for QRB2210 (QCM2290) platforms.
>> While at this, also add QRB2210 RB1 entry which is set to be
>> compatible with QRB2210 soundcard.
>
>
> You explained here what you did, but you should explain why. I don't
> quite get why SoC sound card and RB1 sound card are both needed. I would
> just go with one.
I wanted to go with none in the first place and just make it rb2
sndcard compatible (as a fallback). Then Dmitry suggested to follow other
sndcards patterns and implmenet it like this.
There is also at least one qrb2210/qcm2290-based board -- UNO Q and at this
point I can't say if it will need separate compatble or can use
qcom,qrb2210-sndcard as a fallback.
> Please use subject prefixes matching the subsystem. For bindings, the
> preferred subjects are explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
So the order in subject should be reversed. Got it.
Thanks,
Alexey
Powered by blists - more mailing lists