linux-kernel - Re: [GIT PULL 05/12 for v6.18] pidfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251007143418.GA12329@redhat.com>
Date: Tue, 7 Oct 2025 16:34:19 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Christian Brauner <brauner@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mateusz Guzik <mjguzik@...il.com>
Subject: Re: [GIT PULL 05/12 for v6.18] pidfs

On 10/06, Christian Brauner wrote:
>
> On Wed, Oct 01, 2025 at 04:18:12PM +0200, Oleg Nesterov wrote:
> > On 09/26, Christian Brauner wrote:
> > >
> > > Oleg Nesterov (3):
> > >       pid: make __task_pid_nr_ns(ns => NULL) safe for zombie callers
> > ...
> > > gaoxiang17 (1):
> > >       pid: Add a judgment for ns null in pid_nr_ns
> >
> > Oh... I already tried to complain twice
> >
> > 	https://lore.kernel.org/all/20250819142557.GA11345@redhat.com/
> > 	https://lore.kernel.org/all/20250901153054.GA5587@redhat.com/
> >
> > One of these patches should be reverted. It doesn't really hurt, but it makes
> > no sense to check ns != NULL twice.
>
> Sorry, those somehow got lost.
> Do you mind sending me a revert?

Thanks, will do.

But which one? I am biased, but I'd prefer to revert 006568ab4c5ca2309ceb36
("pid: Add a judgment for ns null in pid_nr_ns")

Mostly because abdfd4948e45c51b1916 ("pid: make __task_pid_nr_ns(ns => NULL)
safe for zombie callers") tries to explain why this change makes sense and
why it is not easy to avoid ns == NULL.

OK?

Oleg.