linux-kernel - Re: [PATCH v4 12/13] nova-core: falcon: Add support to write firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2002AEC7-A3B6-4E77-BDCF-B21E9D7EA0CD@nvidia.com>
Date: Wed, 8 Oct 2025 04:56:56 +0000
From: Joel Fernandes <joelagnelf@...dia.com>
To: Timur Tabi <ttabi@...dia.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Alistair Popple <apopple@...dia.com>, Alexandre Courbot
	<acourbot@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"lossin@...nel.org" <lossin@...nel.org>, "ojeda@...nel.org"
	<ojeda@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>,
	"a.hindborg@...nel.org" <a.hindborg@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, John Hubbard
	<jhubbard@...dia.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, "gary@...yguo.net"
	<gary@...yguo.net>, "lyude@...hat.com" <lyude@...hat.com>
Subject: Re: [PATCH v4 12/13] nova-core: falcon: Add support to write firmware
 version



> On Oct 7, 2025, at 11:21 PM, Timur Tabi <ttabi@...dia.com> wrote:
> 
> On Wed, 2025-10-08 at 11:12 +1100, Alistair Popple wrote:
>> +
>> +    /// Write the application version to the OS register.
>> +    #[expect(dead_code)]
>> +    pub(crate) fn write_os_version(&self, bar: &Bar0, app_version: u32) -> Result<()> {
>> +        regs::NV_PFALCON_FALCON_OS::default()
>> +            .set_value(app_version)
>> +            .write(bar, &E::ID);
>> +        Ok(())
>> +    }
> 
> I should have noticed this in v3, but why return Result here?  This is just like is_riscv_active
> -- this function cannot fail.

Ack. Let us fix. IIRC, it is a remnant from a time when the function could fail.

I can submit a fixup to squash if there are no other changes to the series.

Thanks.