lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aaf218306186aa8959d8f3971a62afb9f229548b.camel@nvidia.com>
Date: Wed, 8 Oct 2025 03:21:10 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Alistair Popple <apopple@...dia.com>, Alexandre Courbot
	<acourbot@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>
CC: "lossin@...nel.org" <lossin@...nel.org>, "ojeda@...nel.org"
	<ojeda@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>,
	"a.hindborg@...nel.org" <a.hindborg@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, John Hubbard
	<jhubbard@...dia.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Joel Fernandes
	<joelagnelf@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>,
	"lyude@...hat.com" <lyude@...hat.com>
Subject: Re: [PATCH v4 12/13] nova-core: falcon: Add support to write firmware
 version

On Wed, 2025-10-08 at 11:12 +1100, Alistair Popple wrote:
> +
> +    /// Write the application version to the OS register.
> +    #[expect(dead_code)]
> +    pub(crate) fn write_os_version(&self, bar: &Bar0, app_version: u32) -> Result<()> {
> +        regs::NV_PFALCON_FALCON_OS::default()
> +            .set_value(app_version)
> +            .write(bar, &E::ID);
> +        Ok(())
> +    }

I should have noticed this in v3, but why return Result here?  This is just like is_riscv_active
-- this function cannot fail.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ