linux-kernel - Re: [PATCH] dt-bindings: i2c: hisilicon,hix5hd2-i2c convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOYRLCGv9_k8i_Vn@shikoro>
Date: Wed, 8 Oct 2025 09:22:20 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Kael D'Alcamo <dev@...l-k.io>
Cc: Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Wei Yan <sledge.yanwei@...wei.com>, linux-i2c@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: hisilicon,hix5hd2-i2c convert to DT
 schema

Hi,

thanks for this conversion!

> +properties:
> +  compatible:
> +    enum:
> +      - hisilicon,hix5hd2-i2c

Question for DT maintainers: Is it preferred to start with 'enum' right
away or to start with 'const' and convert to 'enum' once a second user
appears?

> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0

These should be left out because they come from i2c-controller.yaml?

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - "#address-cells"
> +  - "#size-cells"

Same here for the last two?

Happy hacking,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)