linux-kernel - Re: [PATCH] dt-bindings: i2c: hisilicon,hix5hd2-i2c convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2e81faf-4d2c-40e7-bdf0-e0d41fc76d9c@kernel.org>
Date: Wed, 8 Oct 2025 17:41:17 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Kael D'Alcamo <dev@...l-k.io>
Cc: Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Wei Yan <sledge.yanwei@...wei.com>,
 linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: hisilicon,hix5hd2-i2c convert to DT
 schema

On 08/10/2025 16:22, Wolfram Sang wrote:
> Hi,
> 
> thanks for this conversion!
> 
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - hisilicon,hix5hd2-i2c
> 
> Question for DT maintainers: Is it preferred to start with 'enum' right
> away or to start with 'const' and convert to 'enum' once a second user
> appears?


I don't have preference except: I would suggest using enum if you
already think there will be second variant, because it would save one
re-indent/rewrite of the line.

But in this case of old schema this is unlikely, so really does not
matter for me.

> 
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    const: 0
> 
> These should be left out because they come from i2c-controller.yaml?

Yeah, these are redundant.

> 
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clocks
>> +  - "#address-cells"
>> +  - "#size-cells"
> 
> Same here for the last two?

i2c-controller.yaml does not require these I think for a reason - you
could have enabled empty I2C controller node for user space and having
these required without actual children causes dtc W=1 or W=2 warning.

so yeah, I would propose to drop these as well.


Best regards,
Krzysztof