linux-kernel - Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c33a26a8-a054-4ce6-86d9-4945014f69cf@kernel.org>
Date: Wed, 8 Oct 2025 17:12:01 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pritam Manohar Sutar <pritam.sutar@...sung.com>, vkoul@...nel.org,
 kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 alim.akhtar@...sung.com, andre.draszik@...aro.org, peter.griffin@...aro.org,
 kauschluss@...root.org, ivo.ivanov.ivanov1@...il.com,
 igor.belwon@...tallysanemainliners.org, m.szyprowski@...sung.com,
 s.nawrocki@...sung.com
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, rosa.pila@...sung.com,
 dev.tailor@...sung.com, faraz.ata@...sung.com, muhammed.ali@...sung.com,
 selvarasu.g@...sung.com
Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
 ExynosAutov920 HS phy compatible

On 08/10/2025 13:45, Pritam Manohar Sutar wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: 07 October 2025 11:54 AM
>> To: Pritam Manohar Sutar <pritam.sutar@...sung.com>; vkoul@...nel.org;
>> kishon@...nel.org; robh@...nel.org; krzk+dt@...nel.org;
>> conor+dt@...nel.org; alim.akhtar@...sung.com; andre.draszik@...aro.org;
>> peter.griffin@...aro.org; kauschluss@...root.org;
>> ivo.ivanov.ivanov1@...il.com; igor.belwon@...tallysanemainliners.org;
>> m.szyprowski@...sung.com; s.nawrocki@...sung.com
>> Cc: linux-phy@...ts.infradead.org; devicetree@...r.kernel.org; linux-
>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-samsung-
>> soc@...r.kernel.org; rosa.pila@...sung.com; dev.tailor@...sung.com;
>> faraz.ata@...sung.com; muhammed.ali@...sung.com;
>> selvarasu.g@...sung.com
>> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
>> ExynosAutov920 HS phy compatible
>>
>> On 22/09/2025 14:26, Pritam Manohar Sutar wrote:
>>> This phy needs 0.75v, 0.18v and 3.3v supplies for its internal
>>> functionally. Power Supply's names are as per phy's User Data-Book.
>>> These names, (dvdd, vdd18 and vdd33), are considered  for 0.75v, 1.8v
>>> and 3.3v respectively.
>>> "
>>>
>>>>
>>>> I still cannot find constraints for the rest of properties, though.
>>>
>>> Sorry I didn't get it completely. Can you please elaborate on the same?
>>
>>
>> Writing bindings and introductory talks elaborate on that. You add properties
>> without constraints. That's not what we want. We want constraints.
>>
> 
> Have added only supplies in this patch-set. However, was going 
> through schema example and it says nothing is needed to define
> in terms of supply. 


I don't have original patchset in my inbox anymore, so not sure what was
there, but most likely you miss constraining the presence of these
properties per each variant. IOW, not each of devices in the bindings
have these supplies, so I expect syntax similar as in example-schema.

https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml#L212


Best regards,
Krzysztof