linux-kernel - Re: [PATCH 2/4] mm, swap: rename helper for setup bad slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77e6300f-dde7-4790-9c4c-6b3e7d40516f@redhat.com>
Date: Wed, 8 Oct 2025 12:25:48 +0200
From: David Hildenbrand <david@...hat.com>
To: Kairui Song <ryncsn@...il.com>, linux-mm@...ck.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Kemeng Shi <shikemeng@...weicloud.com>, Kairui Song <kasong@...cent.com>,
 Nhat Pham <nphamcs@...il.com>, Baoquan He <bhe@...hat.com>,
 Barry Song <baohua@...nel.org>, Chris Li <chrisl@...nel.org>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Ying Huang <ying.huang@...ux.alibaba.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mm, swap: rename helper for setup bad slots

On 06.10.25 22:02, Kairui Song wrote:
> From: Kairui Song <kasong@...cent.com>
> 
> The name inc_cluster_info_page is very confusing, as this helper is only
> used during swapon to mark bad slots. Rename it properly and turn the
> VM_BUG_ON in it into WARN_ON to expose more potential issues. Swapon is
> a cold path, so adding more checks should be a good idea.
> 
> No feature change except new WARN_ON.
> 
> Signed-off-by: Kairui Song <kasong@...cent.com>
> ---

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers

David / dhildenb