linux-kernel - Re: [PATCH 3/4] mm, swap: cleanup swap entry allocation parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41e7c36a-1349-4973-b133-316c823ead36@redhat.com>
Date: Wed, 8 Oct 2025 12:26:24 +0200
From: David Hildenbrand <david@...hat.com>
To: Nhat Pham <nphamcs@...il.com>, Kairui Song <ryncsn@...il.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
 Kemeng Shi <shikemeng@...weicloud.com>, Baoquan He <bhe@...hat.com>,
 Barry Song <baohua@...nel.org>, Chris Li <chrisl@...nel.org>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Ying Huang <ying.huang@...ux.alibaba.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mm, swap: cleanup swap entry allocation parameter

>>> diff --git a/mm/swapfile.c b/mm/swapfile.c
>>> index 732e07c70ce9..534b21aeef5a 100644
>>> --- a/mm/swapfile.c
>>> +++ b/mm/swapfile.c
>>> @@ -1425,7 +1425,7 @@ static bool swap_sync_discard(void)
>>>    * Context: Caller needs to hold the folio lock.
>>>    * Return: Whether the folio was added to the swap cache.
>>>    */
>>> -int folio_alloc_swap(struct folio *folio, gfp_t gfp)
>>> +int folio_alloc_swap(struct folio *folio)
>>>   {
>>>          unsigned int order = folio_order(folio);
>>>          unsigned int size = 1 << order;
>>
>> One trivial issue for myself, I better update the kerneldoc too...
>> sorry about this:
>>
> 
> LGTM, with the kerneldoc update:
> 
> Acked-by: Nhat Pham <nphamcs@...il.com>
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers

David / dhildenb