linux-kernel - Re: [PATCH] spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOaEZmrWgy_g0u7c@stanley.mountain>
Date: Wed, 8 Oct 2025 18:33:58 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Mattijs Korpershoek <mkorpershoek@...nel.org>
Cc: Mark Brown <broonie@...nel.org>,
	Khairul Anuar Romli <khairul.anuar.romli@...era.com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: cadence-quadspi: Fix pm_runtime unbalance on dma
 EPROBE_DEFER

On Wed, Oct 08, 2025 at 03:38:39PM +0200, Mattijs Korpershoek wrote:
> In csqspi_probe(), when cqspi_request_mmap_dma() returns -EPROBE_DEFER,
> we handle the error by jumping to probe_setup_failed.
> In that label, we call pm_runtime_disable(), even if we never called
> pm_runtime_enable() before.
> 
> Because of this, the driver cannot probe:
> 
> [    2.690018] cadence-qspi 47040000.spi: No Rx DMA available
> [    2.699735] spi-nor spi0.0: resume failed with -13
> [    2.699741] spi-nor: probe of spi0.0 failed with error -13
> 
> Only call pm_runtime_disable() if it was enabled by adding a new
> label to handle cqspi_request_mmap_dma() failures.
> 
> Fixes: 04a8ff1bc351 ("spi: cadence-quadspi: fix cleanup of rx_chan on failure paths")
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@...nel.org>
> ---
> This has been tested on a AM69 SK board.

The patch seems correct, but the correct Fixes tag is:
Fixes: b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")

regards,
dan carpenter