[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6t5u7pwzztqbkso6nq35y6ohtjywkbacf5cug6gmtfnmnulamc@h4sbsli2bfxe>
Date: Wed, 8 Oct 2025 21:31:06 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: lemans-evk: Add OTG support for
primary USB controller
On Wed, Oct 08, 2025 at 11:30:36PM +0530, Krishna Kurapati wrote:
> Enable OTG support for primary USB controller on EVK Platform. Add
> HD3SS3220 Type-C port controller present between Type-C port and SoC
> that provides role switch notifications to controller.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
> ---
> Changes in v2:
> Removed redundant property of dr_mode setting.
> Added power-role property in connector node.
>
> Link to driver and bindings:
> https://lore.kernel.org/all/20251008175750.1770454-1-krishna.kurapati@oss.qualcomm.com/
>
> Link to v1:
> https://lore.kernel.org/all/20251002172946.589061-1-krishna.kurapati@oss.qualcomm.com/
>
> arch/arm64/boot/dts/qcom/lemans-evk.dts | 122 +++++++++++++++++++++++-
> 1 file changed, 121 insertions(+), 1 deletion(-)
>
> @@ -751,9 +849,31 @@ &ufs_mem_phy {
> };
>
> &usb_0 {
> - dr_mode = "peripheral";
> + usb-role-switch;
This should be a part of the SoC DT.
>
> status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + usb3_hs_ep: endpoint {
> + remote-endpoint = <&usb0_con_hs_ep>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + usb3_role_switch: endpoint {
This is SS lanes endpoint, please name it accordingly
> + remote-endpoint = <&hd3ss3220_out_ep>;
> + };
> + };
> +
> + };
> };
>
> &usb_0_hsphy {
> --
> 2.34.1
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists