linux-kernel - Re: [PATCH] Documentation: sysrq: Remove contradicting sentence on extra /proc/sysrq-trigger characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e29c0d3-f8a0-474c-8d75-74f222621049@infradead.org>
Date: Wed, 8 Oct 2025 19:18:49 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Bagas Sanjaya <bagasdotme@...il.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Documentation <linux-doc@...r.kernel.org>,
 Linux Serial <linux-serial@...r.kernel.org>
Cc: Jonathan Corbet <corbet@....net>, Cengiz Can <cengiz@...nel.wtf>,
 Tomas Mudrunka <tomas.mudrunka@...il.com>, Jiri Slaby
 <jirislaby@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Anselm Schüler <mail@...elmschueler.com>
Subject: Re: [PATCH] Documentation: sysrq: Remove contradicting sentence on
 extra /proc/sysrq-trigger characters



On 10/8/25 4:24 AM, Bagas Sanjaya wrote:
> /proc/sysrq-trigger documentation states that only first character is
> processed and the rest is ignored, yet it is not recommended to write
> any extra characters to it. The latter statement is contradictive as
> these characters are also ignored as implied by preceding sentence.
> 
> Remove it.
> 
> Link: https://lore.kernel.org/lkml/7ca05672-dc20-413f-a923-f77ce0a9d307@anselmschueler.com/
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  Documentation/admin-guide/sysrq.rst | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
> index 9c7aa817adc72d..63ff415ce85d66 100644
> --- a/Documentation/admin-guide/sysrq.rst
> +++ b/Documentation/admin-guide/sysrq.rst
> @@ -77,9 +77,7 @@ On other
>  On all
>  	Write a single character to /proc/sysrq-trigger.
>  	Only the first character is processed, the rest of the string is
> -	ignored. However, it is not recommended to write any extra characters
> -	as the behavior is undefined and might change in the future versions.
> -	E.g.::
> +	ignored. E.g.::
>  
>  		echo t > /proc/sysrq-trigger
>  
> 
> base-commit: c746c3b5169831d7fb032a1051d8b45592ae8d78