linux-kernel - Re: [PATCH] i2c: designware-platdrv: handle reset control deassert error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251009093022.GH2912318@black.igk.intel.com>
Date: Thu, 9 Oct 2025 11:30:22 +0200
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Artem Shimko <a.shimko.dev@...il.com>
Cc: p.zabel@...gutronix.de, andi.shyti@...nel.org,
	andriy.shevchenko@...ux.intel.com, jarkko.nikula@...ux.intel.com,
	jsd@...ihalf.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware-platdrv: handle reset control deassert
 error

Hi,

On Thu, Oct 09, 2025 at 11:37:03AM +0300, Artem Shimko wrote:
> Handle the error returned by reset_control_deassert() in the probe
> function to prevent continuing probe when reset deassertion fails.
> 
> Previously, reset_control_deassert() was called without checking its
> return value, which could lead to probe continuing even when the
> device reset wasn't properly deasserted.
> 
> The fix checks the return value and returns an error with dev_err_probe()
> if reset deassertion fails, providing better error handling and
> diagnostics.
> 
> Signed-off-by: Artem Shimko <a.shimko.dev@...il.com>

Looks good to me,

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>