linux-kernel - Re: [PATCH] i2c: designware-platdrv: handle reset control deassert error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c863512af9a13eb92bde7e0d383d4b4c81e5ce3e.camel@pengutronix.de>
Date: Thu, 09 Oct 2025 11:39:33 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Artem Shimko <a.shimko.dev@...il.com>
Cc: andi.shyti@...nel.org, andriy.shevchenko@...ux.intel.com, 
	jarkko.nikula@...ux.intel.com, jsd@...ihalf.com, linux-i2c@...r.kernel.org,
 	linux-kernel@...r.kernel.org, mika.westerberg@...ux.intel.com
Subject: Re: [PATCH] i2c: designware-platdrv: handle reset control deassert
 error

On Do, 2025-10-09 at 11:37 +0300, Artem Shimko wrote:
> Handle the error returned by reset_control_deassert() in the probe
> function to prevent continuing probe when reset deassertion fails.
> 
> Previously, reset_control_deassert() was called without checking its
> return value, which could lead to probe continuing even when the
> device reset wasn't properly deasserted.
> 
> The fix checks the return value and returns an error with dev_err_probe()
> if reset deassertion fails, providing better error handling and
> diagnostics.
> 
> Signed-off-by: Artem Shimko <a.shimko.dev@...il.com>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp