linux-kernel - Re: [PATCH] i2c: designware-platdrv: handle reset control deassert error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOPX747hVv-JZ71jtam111KYNiCJNLBnNrcQfNO8EEEihfFwwg@mail.gmail.com>
Date: Fri, 24 Oct 2025 11:07:49 +0300
From: Artem Shimko <a.shimko.dev@...il.com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: andi.shyti@...nel.org, andriy.shevchenko@...ux.intel.com, 
	jarkko.nikula@...ux.intel.com, jsd@...ihalf.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, mika.westerberg@...ux.intel.com
Subject: Re: [PATCH] i2c: designware-platdrv: handle reset control deassert error

On Thu, Oct 9, 2025 at 12:39 PM Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> On Do, 2025-10-09 at 11:37 +0300, Artem Shimko wrote:
> > Handle the error returned by reset_control_deassert() in the probe
> > function to prevent continuing probe when reset deassertion fails.
> >
> > Previously, reset_control_deassert() was called without checking its
> > return value, which could lead to probe continuing even when the
> > device reset wasn't properly deasserted.
> >
> > The fix checks the return value and returns an error with dev_err_probe()
> > if reset deassertion fails, providing better error handling and
> > diagnostics.
> >
> > Signed-off-by: Artem Shimko <a.shimko.dev@...il.com>
>
> Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

Hi Philipp,

Should I do something to bring the changes to linux-next?

--
Best regards,
Artem