linux-kernel - Re: [PATCH v2] ioctl_pidfd05: accept both EINVAL and ENOTTY as valid errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251024081556.GA570960@pevik>
Date: Fri, 24 Oct 2025 10:15:56 +0200
From: Petr Vorel <pvorel@...e.cz>
To: Anders Roxell <anders.roxell@...aro.org>
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>, ltp@...ts.linux.it,
	lkft@...aro.org, arnd@...nel.org, dan.carpenter@...aro.org,
	jack@...e.cz, brauner@...nel.org, chrubis@...e.cz,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	regressions@...ts.linux.dev, aalbersh@...nel.org, arnd@...db.de,
	viro@...iv.linux.org.uk, benjamin.copeland@...aro.org,
	andrea.cervesato@...e.com, lkft-triage@...ts.linaro.org,
	Avinesh Kumar <akumar@...e.de>
Subject: Re: [PATCH v2] ioctl_pidfd05: accept both EINVAL and ENOTTY as valid
 errors

Hi all,

> On Thu, 23 Oct 2025 at 18:44, Naresh Kamboju <naresh.kamboju@...aro.org> wrote:

> > Newer kernels (since ~v6.18-rc1) return ENOTTY instead of EINVAL when
> > invoking ioctl(pidfd, PIDFD_GET_INFO_SHORT, info_invalid). Update the
> > test to accept both EINVAL and ENOTTY as valid errors to ensure
> > compatibility across different kernel versions.

I dared to add a commit which caused the change (found by Cyril Hrubis):
3c17001b21b9f ("pidfs: validate extensible ioctls")

and merged!

Thanks for fix and review!

Kind regards,
Petr