linux-kernel - Re: [PATCH v3] ring buffer: Propagate __rb_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251009095744.443db14b@gandalf.local.home>
Date: Thu, 9 Oct 2025 09:57:44 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Ankit Khushwaha <ankitkhushwaha.linux@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 david.hunter.linux@...il.com, skhan@...uxfoundation.org,
 linux-kernel-mentees@...ts.linuxfoundation.org, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 syzbot+ddc001b92c083dbf2b97@...kaller.appspotmail.com
Subject: Re: [PATCH v3] ring buffer: Propagate __rb_map_vma return value to
 caller

On Thu,  9 Oct 2025 10:23:45 +0530
Ankit Khushwaha <ankitkhushwaha.linux@...il.com> wrote:

> The return value from __rb_map_vma(), which rejects writable or
> executable mappings (VM_WRITE, VM_EXEC, or !VM_MAYSHARE), was being
> ignored.  As a result the caller of `__rb_map_vma` always returned 0 even when the
> mapping had actually failed, allowing it to proceed with an invalid VMA.
> 
> Reported-by: syzbot+ddc001b92c083dbf2b97@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?id=194151be8eaebd826005329b2e123aecae714bdb
> Signed-off-by: Ankit Khushwaha <ankitkhushwaha.linux@...il.com>
> ---
> 
> Changes in v3: https://lore.kernel.org/linux-trace-kernel/20251008172516.20697-1-ankitkhushwaha.linux@gmail.com/
> * Same as v2:)
> 
> Changes in v2: https://lore.kernel.org/linux-trace-kernel/20251007171256.20884-1-ankitkhushwaha.linux@gmail.com/
> * applied minor cleanup suggested by Steve in v1
> 

This is good practice, but I already pulled in v2.

-- Steve

> ---
>  kernel/trace/ring_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 43460949ad3f..1244d2c5c384 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -7273,7 +7273,7 @@ int ring_buffer_map(struct trace_buffer *buffer, int cpu,
>  		atomic_dec(&cpu_buffer->resize_disabled);
>  	}
>  
> -	return 0;
> +	return err;
>  }
>  
>  int ring_buffer_unmap(struct trace_buffer *buffer, int cpu)