linux-kernel - Re: [PATCH] powerpc/addnote: Fix overflow on 32-bit builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60593288-c747-42c5-b05d-27a81ab46021@csgroup.eu>
Date: Thu, 9 Oct 2025 15:51:54 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH] powerpc/addnote: Fix overflow on 32-bit builds



Le 22/04/2025 à 04:31, Ben Collins a écrit :
> The PUT_64[LB]E() macros need to cast the value to unsigned long long
> like the GET_64[LB]E() macros. Caused lots of warnings when compiled
> on 32-bit, and clobbered addresses (36-bit P4080).
> 
> Signed-off-by: Ben Collins <bcollins@...nel.org>
> Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: linuxppc-dev@...ts.ozlabs.org

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   arch/powerpc/boot/addnote.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/boot/addnote.c b/arch/powerpc/boot/addnote.c
> index 53b3b2621457d..78704927453aa 100644
> --- a/arch/powerpc/boot/addnote.c
> +++ b/arch/powerpc/boot/addnote.c
> @@ -68,8 +68,8 @@ static int e_class = ELFCLASS32;
>   #define PUT_16BE(off, v)(buf[off] = ((v) >> 8) & 0xff, \
>   			 buf[(off) + 1] = (v) & 0xff)
>   #define PUT_32BE(off, v)(PUT_16BE((off), (v) >> 16L), PUT_16BE((off) + 2, (v)))
> -#define PUT_64BE(off, v)((PUT_32BE((off), (v) >> 32L), \
> -			  PUT_32BE((off) + 4, (v))))
> +#define PUT_64BE(off, v)((PUT_32BE((off), (unsigned long long)(v) >> 32L), \
> +			  PUT_32BE((off) + 4, (unsigned long long)(v))))
>   
>   #define GET_16LE(off)	((buf[off]) + (buf[(off)+1] << 8))
>   #define GET_32LE(off)	(GET_16LE(off) + (GET_16LE((off)+2U) << 16U))
> @@ -78,7 +78,8 @@ static int e_class = ELFCLASS32;
>   #define PUT_16LE(off, v) (buf[off] = (v) & 0xff, \
>   			  buf[(off) + 1] = ((v) >> 8) & 0xff)
>   #define PUT_32LE(off, v) (PUT_16LE((off), (v)), PUT_16LE((off) + 2, (v) >> 16L))
> -#define PUT_64LE(off, v) (PUT_32LE((off), (v)), PUT_32LE((off) + 4, (v) >> 32L))
> +#define PUT_64LE(off, v) (PUT_32LE((off), (unsigned long long)(v)), \
> +			  PUT_32LE((off) + 4, (unsigned long long)(v) >> 32L))
>   
>   #define GET_16(off)	(e_data == ELFDATA2MSB ? GET_16BE(off) : GET_16LE(off))
>   #define GET_32(off)	(e_data == ELFDATA2MSB ? GET_32BE(off) : GET_32LE(off))