Message-ID: <7a818442-2c5b-433d-874f-4a11ce3ed42f@csgroup.eu>
Date: Thu, 9 Oct 2025 16:02:37 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: j.ne@...teo.net, Scott Wood <oss@...error.net>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] dt-bindings: powerpc: Add Freescale/NXP MPC83xx SoCs



Le 12/04/2025 à 15:55, J. Neuschäfer via B4 Relay a écrit :
> From: "J. Neuschäfer" <j.ne@...teo.net>
> 
> Add a new binding for MPC83xx platforms, describing the board compatible
> strings used in currently existing device trees.
> 
> Note that the SoC bus is called immr@... in many existing devicetrees,
> but this contradicts the simple-bus binding.
> 
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> ---

Looks consistant with mpc83xx platforms.

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

For correctness with dt-bindings documentation format check with DT 
maintainers/reviewers.

> Changes in v4:
> - Rebase on v6.15-rc1
> - Link to v3: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fr%2F20250220-ppcyaml-soc-v3-1-b8c98a61bc1a%40posteo.net&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C6a17702bd4a14e74161208dd79cbabc9%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638800637855467799%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=bmGcvUV0O7kyAlbwQQw1Ct8a%2FFz7ZI1Ama79vSykKjo%3D&reserved=0
> ---
> 
> V4:
> - Try to list all existing compatible strings for MPC83xx boards
> 
> V3:
> - split out as a single patch
> - otherwise no changes
> 
> V2:
> - part of series [PATCH v2 00/12] YAML conversion of several Freescale/PowerPC DT bindings
>    Link: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20250207-ppcyaml-v2-1-8137b0c42526%40posteo.net%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C6a17702bd4a14e74161208dd79cbabc9%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638800637855486884%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=JcWFEfu6kvOEwZPXGlH1wG3Ab2zyukRXva%2FW2sr05lA%3D&reserved=0
> - trim subject line
> - fix property order to comply with dts coding style
> - add Rob Herrings's R-b tag
> ---
>   .../bindings/powerpc/fsl/fsl,mpc83xx.yaml          | 93 ++++++++++++++++++++++
>   1 file changed, 93 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fsl,mpc83xx.yaml b/Documentation/devicetree/bindings/powerpc/fsl/fsl,mpc83xx.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..9e37d155c5829a652d1e4e59536b6586a58d530e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fsl,mpc83xx.yaml
> @@ -0,0 +1,93 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fpowerpc%2Ffsl%2Ffsl%2Cmpc83xx.yaml%23&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C6a17702bd4a14e74161208dd79cbabc9%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638800637855503120%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=5X55e7ezKH%2ByZkaMchZ3iEIIKt1cLZBcDIsUqyMiBA0%3D&reserved=0
> +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C6a17702bd4a14e74161208dd79cbabc9%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638800637855517944%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=9%2BNfMJcauF%2FFaVQpIovnwAKbRkclTrmZRPehLopstsM%3D&reserved=0
> +
> +title: Freescale PowerQUICC II Pro (MPC83xx) platforms
> +
> +maintainers:
> +  - J. Neuschäfer <j.ne@...teo.net>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: MPC83xx Reference Design Boards
> +        items:
> +          - enum:
> +              - fsl,mpc8308rdb
> +              - fsl,mpc8315erdb
> +              - fsl,mpc8360rdk
> +              - fsl,mpc8377rdb
> +              - fsl,mpc8377wlan
> +              - fsl,mpc8378rdb
> +              - fsl,mpc8379rdb
> +
> +      - description: MPC8313E Reference Design Board
> +        items:
> +          - const: MPC8313ERDB
> +          - const: MPC831xRDB
> +          - const: MPC83xxRDB
> +
> +      - description: MPC8323E Reference Design Board
> +        items:
> +          - const: MPC8323ERDB
> +          - const: MPC832xRDB
> +          - const: MPC83xxRDB
> +
> +      - description: MPC8349E-mITX(-GP) Reference Design Platform
> +        items:
> +          - enum:
> +              - MPC8349EMITX
> +              - MPC8349EMITXGP
> +          - const: MPC834xMITX
> +          - const: MPC83xxMITX
> +
> +      - description: Keymile KMETER1 board
> +        const: keymile,KMETER1
> +
> +      - description: MPC8308 P1M board
> +        const: denx,mpc8308_p1m
> +
> +patternProperties:
> +  "^soc@.*$":
> +    type: object
> +    properties:
> +      compatible:
> +        oneOf:
> +          - items:
> +              - enum:
> +                  - fsl,mpc8315-immr
> +                  - fsl,mpc8308-immr
> +              - const: simple-bus
> +          - items:
> +              - const: fsl,mpc8360-immr
> +              - const: fsl,immr
> +              - const: fsl,soc
> +              - const: simple-bus
> +          - const: simple-bus
> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    / {
> +        compatible = "fsl,mpc8315erdb";
> +        model = "MPC8315E-RDB";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        soc@...00000 {
> +            compatible = "fsl,mpc8315-immr", "simple-bus";
> +            reg = <0xe0000000 0x00000200>;
> +            #address-cells = <1>;
> +            #size-cells = <1>;
> +            device_type = "soc";
> +            ranges = <0 0xe0000000 0x00100000>;
> +            bus-frequency = <0>;
> +        };
> +    };
> +
> +...
> 
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250220-ppcyaml-soc-cae1f14cf389
> 
> Best regards,

Powered by blists - more mailing lists