linux-kernel - Re: [PATCH v15 6/6] PCI: cadence: Use cdns_pcie_find_*capability() to avoid hardcoding offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOfMk9BW8BH2P30V@laps>
Date: Thu, 9 Oct 2025 10:54:11 -0400
From: Sasha Levin <sashal@...nel.org>
To: Hans Zhang <18255117159@....com>
Cc: lpieralisi@...nel.org, kwilczynski@...nel.org, bhelgaas@...gle.com,
	helgaas@...nel.org, jingoohan1@...il.com, mani@...nel.org,
	robh@...nel.org, ilpo.jarvinen@...ux.intel.com,
	schnelle@...ux.ibm.com, gbayer@...ux.ibm.com, lukas@...ner.de,
	arnd@...nel.org, geert@...ux-m68k.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v15 6/6] PCI: cadence: Use cdns_pcie_find_*capability()
 to avoid hardcoding offsets

On Wed, Aug 13, 2025 at 10:45:29PM +0800, Hans Zhang wrote:
>@@ -249,9 +252,10 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn, u8 vfn)
> {
> 	struct cdns_pcie_ep *ep = epc_get_drvdata(epc);
> 	struct cdns_pcie *pcie = &ep->pcie;
>-	u32 cap = CDNS_PCIE_EP_FUNC_MSI_CAP_OFFSET;
> 	u16 flags, mme;
>+	u8 cap;
>
>+	cap = cdns_pcie_find_capability(pcie, PCI_CAP_ID_MSIX);

We should be passing PCI_CAP_ID_MSI, not PCI_CAP_ID_MSIX here, right?

-- 
Thanks,
Sasha