linux-kernel - Re: [PATCH v3] hung_task: Panic after fixed number of hung tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0aea408f-f6d7-4e2d-8cee-1801ad7f3139@web.de>
Date: Sun, 12 Oct 2025 15:26:20 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Li RongQing <lirongqing@...du.com>, linux-doc@...r.kernel.org,
 linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 wireguard@...ts.zx2c4.com, Andrew Jeffery <andrew@...econstruct.com.au>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Anshuman Khandual <anshuman.khandual@....com>, Arnd Bergmann
 <arnd@...db.de>, David Hildenbrand <david@...hat.com>,
 Feng Tang <feng.tang@...ux.alibaba.com>, Florian Westphal <fw@...len.de>,
 Jakub Kicinski <kuba@...nel.org>, "Jason A . Donenfeld" <Jason@...c4.com>,
 Joel Granados <joel.granados@...nel.org>, Joel Stanley <joel@....id.au>,
 Jonathan Corbet <corbet@....net>, Kees Cook <kees@...nel.org>,
 Lance Yang <lance.yang@...ux.dev>, "Liam R . Howlett"
 <Liam.Howlett@...cle.com>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 "Paul E . McKenney" <paulmck@...nel.org>,
 Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
 Petr Mladek <pmladek@...e.com>, Phil Auld <pauld@...hat.com>,
 Randy Dunlap <rdunlap@...radead.org>, Russell King <linux@...linux.org.uk>,
 Shuah Khan <shuah@...nel.org>, Simon Horman <horms@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v3] hung_task: Panic after fixed number of hung tasks

…
> This patch extends the …

Will another imperative wording approach become more helpful for an improved
change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94

…
> +++ b/kernel/hung_task.c
…
@@ -229,9 +232,11 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
…
>  	trace_sched_process_hang(t);
>  
> -	if (sysctl_hung_task_panic) {
> +	if (sysctl_hung_task_panic &&
> +			(total_hung_task >= sysctl_hung_task_panic)) {
…

I suggest to use the following source code variant instead.

	if (sysctl_hung_task_panic && total_hung_task >= sysctl_hung_task_panic) {

Regards,
Markus