[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <912c0ccd-40cd-402e-ac9f-f86be48aa072@kernel.org>
Date: Sun, 12 Oct 2025 04:46:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>,
Pankaj Patil <pankaj.patil@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
Subject: Re: [PATCH 04/24] arm64: dts: qcom: glymur: Add QUPv3 configuration
for serial engines
On 11/10/2025 13:11, Abel Vesa wrote:
> On 25-10-11 14:06:44, Abel Vesa wrote:
>> On 25-09-25 12:02:12, Pankaj Patil wrote:
>>> From: Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
>>> + dma-channels = <16>;
>>> + dma-channel-mask = <0x3f>;
>>> + #dma-cells = <3>;
>>> + iommus = <&apps_smmu 0xd76 0x0>;
>>> + status = "ok";
>>
>> s/ok/okay/
>>
>> Everywhere actually.
>>
>
> Actually no. Maybe drop entirely like Konrad already suggested.
>
> But then everywhere else you do "ok" please replace with "okay",
> otherwise dtbs_check complains.
I actually wonder how this passed any dtbs tests... or it wasn't tested
at all?
Best regards,
Krzysztof
Powered by blists - more mailing lists