linux-kernel - Re: [PATCH v9 15/15] arm: dts: airoha: en7523: add SNAND node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9746976a-ade4-4551-920c-ffbb914a4e10@kernel.org>
Date: Sun, 12 Oct 2025 04:48:41 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Lorenzo Bianconi <lorenzo@...nel.org>,
 Ray Liu <ray.liu@...oha.com>, Mark Brown <broonie@...nel.org>,
 Andy Shevchenko <andy@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Cc: Andreas Gnau <andreas.gnau@...sys.eu>
Subject: Re: [PATCH v9 15/15] arm: dts: airoha: en7523: add SNAND node

On 11/10/2025 07:01, Mikhail Kshevetskiy wrote:
> On 11.10.2025 02:42, Krzysztof Kozlowski wrote:
>> On 10/10/2025 22:45, Mikhail Kshevetskiy wrote:
>>> Add SNAND node to enable support of attached SPI-NAND on the EN7523 SoC.
>>>
>>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>
>>> ---
>>>  arch/arm/boot/dts/airoha/en7523.dtsi | 21 +++++++++++++++++++++
>>>  1 file changed, 21 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi
>>> index b523a868c4ad..78e351eb787a 100644
>>> --- a/arch/arm/boot/dts/airoha/en7523.dtsi
>>> +++ b/arch/arm/boot/dts/airoha/en7523.dtsi
>>> @@ -203,4 +203,25 @@ pcie_intc1: interrupt-controller {
>>>  			#interrupt-cells = <1>;
>>>  		};
>>>  	};
>>> +
>>> +	spi_ctrl: spi@...10000 {
>>> +		compatible = "airoha,en7581-snand";
>> NAK, now I found this... Respond to comments instead of ignoring them.
>>
>> Three versions within few hours, that's not acceptable. Outside of the
>> merge window the expectation is minimum 24h difference. Within merge
>> window this is just spamming.
> 
> 
> I already lost any hope to merge this to linux-3.18, so no problem.
> 
> Could you and Rob explain me this compatible issue? I got a feeling that
> Rob telling me to keep "airoha,en7581-snand" compatible while you are
> telling the opposite. As for me the use of "airoha,en7523-snand" or
> maybe "airoha,en75xx-snand" for both en7523 & en7581 chips is the best.
> 
> Is there any policy? Could you provide a link?

The policy is described in writing bindings. I also explained it in
greater details in my recent OSSEU introductory talk. You need two
compatibles.

Best regards,
Krzysztof