linux-kernel - Re: [PATCH] hwmon: gpd-fan: Fix error handling in gpd_fan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dc1ce09-98b4-4c48-971a-3ecb5ed9882b@web.de>
Date: Sun, 12 Oct 2025 19:19:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
 linux-hwmon@...r.kernel.org, Cryolitia PukNgae <cryolitia@...ontech.com>,
 Günter Röck <linux@...ck-us.net>
Cc: kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>, Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] hwmon: gpd-fan: Fix error handling in gpd_fan_probe()

> When devm_request_region(0 fails to get a region regrion would be NULL
> and devm_hwmon_device_register_with_info() fails, best to propagate
> the hwmon dev to PTR_ERR() as opposed to region.

Will another imperative wording approach become more helpful for an improved
change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94

Regards,
Markus