linux-kernel - Re: [PATCH] hwmon: gpd-fan: Fix error handling in gpd_fan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f66fc8e9-1564-4c65-ad27-a7525a081aa3@roeck-us.net>
Date: Sun, 12 Oct 2025 10:58:27 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Cryolitia PukNgae <cryolitia@...ontech.com>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
	dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
	error27@...il.com
Subject: Re: [PATCH] hwmon: gpd-fan: Fix error handling in gpd_fan_probe()

On Fri, Oct 10, 2025 at 01:44:46PM -0700, Harshit Mogalapalli wrote:
> When devm_request_region(0 fails to get a region regrion would be NULL
> and devm_hwmon_device_register_with_info() fails, best to propagate
> the hwmon dev to PTR_ERR() as opposed to region.
> 
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> Reviewed-by: Cryolitia PukNgae <cryolitia@...ontech.com>
> ---

Appied after updating the subject.

Thanks,
Guenter