linux-kernel - Re: [PATCH 10/32] media: i2c: imx335: Use %pe format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiDSCsuPkdz0=U2b_mNh4TWTNztAd9qEwJaiMRdGy1sf3UEbA@mail.gmail.com>
Date: Mon, 13 Oct 2025 17:55:51 +0200
From: Ricardo Ribalda <ribalda@...omium.org>
To: Kieran Bingham <kieran.bingham@...asonboard.com>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Andrew-CT Chen <andrew-ct.chen@...iatek.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>, Bingbu Cao <bingbu.cao@...el.com>, 
	Dafna Hirschfeld <dafna@...tmail.com>, Daniel Scally <djrscally@...il.com>, 
	Dave Stevenson <dave.stevenson@...pberrypi.com>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Fabio Estevam <festevam@...il.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Hans Verkuil <hverkuil@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Jacopo Mondi <jacopo+renesas@...ndi.org>, 
	Jacopo Mondi <jacopo@...ndi.org>, Julien Massot <julien.massot@...labora.com>, 
	Krzysztof Hałasa <khalasa@...p.pl>, 
	Krzysztof Kozlowski <krzk@...nel.org>, 
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Leon Luo <leonl@...pardimaging.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Purism Kernel Team <kernel@...i.sm>, 
	Rui Miguel Silva <rmfrfs@...il.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>, 
	Sylvain Petinot <sylvain.petinot@...s.st.com>, Sylwester Nawrocki <s.nawrocki@...sung.com>, 
	Tianshu Qiu <tian.shu.qiu@...el.com>, Tiffany Lin <tiffany.lin@...iatek.com>, 
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, 
	Yemike Abhilash Chandra <y-abhilashchandra@...com>, Yong Zhi <yong.zhi@...el.com>, 
	Yunfei Dong <yunfei.dong@...iatek.com>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
	imx@...ts.linux.dev, linux-renesas-soc@...r.kernel.org, 
	linux-rockchip@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH 10/32] media: i2c: imx335: Use %pe format specifier

Hi Kieran

On Mon, 13 Oct 2025 at 17:03, Kieran Bingham
<kieran.bingham@...asonboard.com> wrote:
>
> Quoting Ricardo Ribalda (2025-10-13 15:14:50)
> > The %pe format specifier is designed to print error pointers. It prints
> > a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> > omitting PTR_ERR().
> >
> > This patch fixes this cocci report:
> > ./i2c/imx335.c:1013:3-10: WARNING: Consider using %pe to print PTR_ERR()
>
> Ohhh nice. Is this new ? First I've come across it.

It is actually from 2019:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=57f5677e535ba24b8926a7125be2ef8d7f09323c

I just learned about it because there is a new check in coccinelle :).

It is pretty cool, but you need to be careful to check IS_ERR(ptr)
before doing the printk, otherwise %pe will print the pointer value.

Regards!

>
>
>
> > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> > ---
> >  drivers/media/i2c/imx335.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> > index c043df2f15fb25b3a56422092f99a1fd9a508fa9..71ed9a0d84a252ee362621c4d38001508fb86d28 100644
> > --- a/drivers/media/i2c/imx335.c
> > +++ b/drivers/media/i2c/imx335.c
> > @@ -1009,8 +1009,8 @@ static int imx335_parse_hw_config(struct imx335 *imx335)
> >         imx335->reset_gpio = devm_gpiod_get_optional(imx335->dev, "reset",
> >                                                      GPIOD_OUT_HIGH);
> >         if (IS_ERR(imx335->reset_gpio)) {
> > -               dev_err(imx335->dev, "failed to get reset gpio %ld\n",
> > -                       PTR_ERR(imx335->reset_gpio));
> > +               dev_err(imx335->dev, "failed to get reset gpio %pe\n",
> > +                       imx335->reset_gpio);
>
> Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>
>
> >                 return PTR_ERR(imx335->reset_gpio);
> >         }
> >
> >
> > --
> > 2.51.0.760.g7b8bcc2412-goog
> >



-- 
Ricardo Ribalda