linux-kernel - Re: [PATCH 05/32] media: ar0521: Use %pe format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3ldlertys.fsf@t19.piap.pl>
Date: Tue, 14 Oct 2025 06:24:43 +0200
From: Krzysztof Hałasa <khalasa@...p.pl>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,  Dmitry Torokhov
 <dmitry.torokhov@...il.com>,  Mauro Carvalho Chehab <mchehab@...nel.org>,
  Hans Verkuil <hverkuil@...nel.org>,  Sakari Ailus
 <sakari.ailus@...ux.intel.com>,  Tomi Valkeinen
 <tomi.valkeinen@...asonboard.com>,  Leon Luo <leonl@...pardimaging.com>,
  Kieran Bingham <kieran.bingham@...asonboard.com>,  Jacopo Mondi
 <jacopo+renesas@...ndi.org>,  Kieran Bingham
 <kieran.bingham+renesas@...asonboard.com>,  Laurent Pinchart
 <laurent.pinchart+renesas@...asonboard.com>,  Niklas Söderlund
 <niklas.soderlund+renesas@...natech.se>,  Julien Massot
 <julien.massot@...labora.com>,  Jacopo Mondi <jacopo@...ndi.org>,  Daniel
 Scally <djrscally@...il.com>,  Dave Stevenson
 <dave.stevenson@...pberrypi.com>,  Benjamin Mugnier
 <benjamin.mugnier@...s.st.com>,  Sylvain Petinot
 <sylvain.petinot@...s.st.com>,  Yong Zhi <yong.zhi@...el.com>,  Bingbu Cao
 <bingbu.cao@...el.com>,  Tianshu Qiu <tian.shu.qiu@...el.com>,  Tiffany
 Lin <tiffany.lin@...iatek.com>,  Andrew-CT Chen
 <andrew-ct.chen@...iatek.com>,  Yunfei Dong <yunfei.dong@...iatek.com>,
  Matthias Brugger <matthias.bgg@...il.com>,  AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>,  Rui Miguel Silva
 <rmfrfs@...il.com>,  Laurent Pinchart <laurent.pinchart@...asonboard.com>,
  Martin Kepplinger <martink@...teo.de>,  Purism Kernel Team
 <kernel@...i.sm>,  Shawn Guo <shawnguo@...nel.org>,  Sascha Hauer
 <s.hauer@...gutronix.de>,  Pengutronix Kernel Team
 <kernel@...gutronix.de>,  Fabio Estevam <festevam@...il.com>,  Dafna
 Hirschfeld <dafna@...tmail.com>,  Heiko Stuebner <heiko@...ech.de>,
  Sylwester Nawrocki <s.nawrocki@...sung.com>,  Krzysztof Kozlowski
 <krzk@...nel.org>,  Alim Akhtar <alim.akhtar@...sung.com>,  Yemike
 Abhilash Chandra <y-abhilashchandra@...com>,  Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  linux-input@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-media@...r.kernel.org,
  linux-arm-kernel@...ts.infradead.org,
  linux-mediatek@...ts.infradead.org,  imx@...ts.linux.dev,
  linux-renesas-soc@...r.kernel.org,  linux-rockchip@...ts.infradead.org,
  linux-samsung-soc@...r.kernel.org,  linux-staging@...ts.linux.dev
Subject: Re: [PATCH 05/32] media: ar0521: Use %pe format specifier

Ricardo Ribalda <ribalda@...omium.org> writes:

> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR()
>
> This patch fixes this cocci report:
> ./i2c/ar0521.c:1113:31-38: WARNING: Consider using %pe to print PTR_ERR()
>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Thanks,
Acked-by: Krzysztof Hałasa <khalasa@...p.pl>

> --- a/drivers/media/i2c/ar0521.c
> +++ b/drivers/media/i2c/ar0521.c
> @@ -1109,8 +1109,8 @@ static int ar0521_probe(struct i2c_client *client)
>                                                 ar0521_supply_names[cnt]);
>
>                 if (IS_ERR(supply)) {
> -                       dev_info(dev, "no %s regulator found: %li\n",
> -                                ar0521_supply_names[cnt], PTR_ERR(supply));
> +                       dev_info(dev, "no %s regulator found: %pe\n",
> +                                ar0521_supply_names[cnt], supply);
>                         return PTR_ERR(supply);
>                 }
>                 sensor->supplies[cnt] = supply;

-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa