linux-kernel - Re: [PATCH 25/32] media: imx8mq-mipi-csi2: Use %pe format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f30b137685be9148e69f18065d811d011bfe3409.camel@posteo.de>
Date: Tue, 14 Oct 2025 07:07:05 +0000
From: Martin Kepplinger-Novakovic <martink@...teo.de>
To: Ricardo Ribalda <ribalda@...omium.org>, Linus Walleij	
 <linus.walleij@...aro.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
 Mauro Carvalho Chehab	 <mchehab@...nel.org>, Hans Verkuil
 <hverkuil@...nel.org>, Sakari Ailus	 <sakari.ailus@...ux.intel.com>,
 Krzysztof Hałasa	 <khalasa@...p.pl>, Tomi Valkeinen
 <tomi.valkeinen@...asonboard.com>, Leon Luo	 <leonl@...pardimaging.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,  Jacopo Mondi
 <jacopo+renesas@...ndi.org>, Kieran Bingham
 <kieran.bingham+renesas@...asonboard.com>,  Laurent Pinchart
 <laurent.pinchart+renesas@...asonboard.com>, Niklas
 Söderlund	 <niklas.soderlund+renesas@...natech.se>,
 Julien Massot	 <julien.massot@...labora.com>, Jacopo Mondi
 <jacopo@...ndi.org>, Daniel Scally	 <djrscally@...il.com>, Dave Stevenson
 <dave.stevenson@...pberrypi.com>,  Benjamin Mugnier
 <benjamin.mugnier@...s.st.com>, Sylvain Petinot
 <sylvain.petinot@...s.st.com>, Yong Zhi	 <yong.zhi@...el.com>, Bingbu Cao
 <bingbu.cao@...el.com>, Tianshu Qiu	 <tian.shu.qiu@...el.com>, Tiffany Lin
 <tiffany.lin@...iatek.com>, Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
 Yunfei Dong <yunfei.dong@...iatek.com>, Matthias Brugger
 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno	
 <angelogioacchino.delregno@...labora.com>, Rui Miguel Silva
 <rmfrfs@...il.com>,  Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Purism Kernel Team <kernel@...i.sm>, Shawn Guo	 <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Dafna
 Hirschfeld	 <dafna@...tmail.com>, Heiko Stuebner <heiko@...ech.de>,
 Sylwester Nawrocki	 <s.nawrocki@...sung.com>, Krzysztof Kozlowski
 <krzk@...nel.org>, Alim Akhtar	 <alim.akhtar@...sung.com>, Yemike Abhilash
 Chandra <y-abhilashchandra@...com>,  Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, imx@...ts.linux.dev, 
	linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 25/32] media: imx8mq-mipi-csi2: Use %pe format specifier

Am Montag, dem 13.10.2025 um 14:15 +0000 schrieb Ricardo Ribalda:
> The %pe format specifier is designed to print error pointers. It
> prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR().
> 
> This patch fixes this cocci report:
> ./platform/nxp/imx8mq-mipi-csi2.c:422:23-30: WARNING: Consider using
> %pe to print PTR_ERR()
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
>  drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> index
> 3a4645f59a44028fdca82a4d8393e1a0a6ba88f0..d333ff43539f061b8b9cf88af2c
> da8c44b3ec2a9 100644
> --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> @@ -418,8 +418,8 @@ static int imx8mq_mipi_csi_calc_hs_settle(struct
> csi_state *state,
>  
>  	src_pad = media_entity_remote_source_pad_unique(&sd_state-
> >sd->entity);
>  	if (IS_ERR(src_pad)) {
> -		dev_err(state->dev, "can't get source pad of %s
> (%ld)\n",
> -			sd_state->sd->name, PTR_ERR(src_pad));
> +		dev_err(state->dev, "can't get source pad of %s
> (%pe)\n",
> +			sd_state->sd->name, src_pad);
>  		return PTR_ERR(src_pad);
>  	}
>  

Reviewed-by: Martin Kepplinger-Novakovic <martink@...teo.de>

thanks you,

                             martin