linux-kernel - Re: [PATCH v3] audit: include source and destination ports to NETFILTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAABTaaBO2KBujB=bqvyumO2xW=JCxKP0hc87myqcLF3pbxSorA@mail.gmail.com>
Date: Mon, 13 Oct 2025 16:11:20 -0300
From: Ricardo Robaina <rrobaina@...hat.com>
To: Paul Moore <paul@...l-moore.com>
Cc: Florian Westphal <fw@...len.de>, audit@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netfilter-devel@...r.kernel.org, coreteam@...filter.org, eparis@...hat.com, 
	pablo@...filter.org, kadlec@...filter.org, ej@...i.de
Subject: Re: [PATCH v3] audit: include source and destination ports to NETFILTER_PKT

On Mon, Oct 13, 2025 at 3:51 PM Paul Moore <paul@...l-moore.com> wrote:
>
> On Mon, Oct 13, 2025 at 2:48 PM Paul Moore <paul@...l-moore.com> wrote:
> > On Fri, Oct 3, 2025 at 11:43 AM Ricardo Robaina <rrobaina@...hat.com> wrote:
> > > On Sat, Sep 27, 2025 at 7:45 AM Florian Westphal <fw@...len.de> wrote:
> > > > Ricardo Robaina <rrobaina@...hat.com> wrote:
> >
> > ...
> >
> > > > Maybe Paul would be open to adding something like audit_log_packet() to
> > > > kernel/audit.c and then have xt_AUDIT.c and nft_log.c just call the
> > > > common helper.
> > >
> > > It sounds like a good idea to me. What do you think, Paul?
> >
> > Seems like a good idea to me too.
>
> A quick follow-up to this ... when you are doing the work Ricardo,
> please do this as a two patch patchset; the first patch should
> introduce a new common function called by both audit_tg() and
> nft_log_eval_audit(), and the second patch should add new port
> information to the audit record.
>
> --
> paul-moore.com
>

Thanks for the tip, Paul! I'll work on it next week.