linux-kernel - Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251013205531.GA863704@bhelgaas>
Date: Mon, 13 Oct 2025 15:55:31 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: "Mario Limonciello (AMD)" <superm1@...nel.org>,
	David Airlie <airlied@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	Simona Vetter <simona@...ll.ch>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
	Daniel Dadap <ddadap@...dia.com>, regressions@...ts.linux.dev
Subject: Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware_default() with
 a screen info check

[+cc regressions]

On Sun, Oct 12, 2025 at 11:23:02AM -0700, Eric Biggers wrote:
> On Mon, Aug 11, 2025 at 11:26:04AM -0500, Mario Limonciello (AMD) wrote:
> > vga_is_firmware_default() checks firmware resources to find the owner
> > framebuffer resources to find the firmware PCI device.  This is an
> > open coded implementation of screen_info_pci_dev().  Switch to using
> > screen_info_pci_dev() instead.
> > 
> > Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > Suggested-by: Thomas Zimmermann <tzimmermann@...e.de>
> > Signed-off-by: Mario Limonciello (AMD) <superm1@...nel.org>
> 
> I'm getting a black screen on boot on mainline, and it bisected to this
> commit.  Reverting this commit fixed it.

#regzbot introduced: 337bf13aa9dd ("PCI/VGA: Replace vga_is_firmware_default() with a screen info check")
#regzbot link: https://lore.kernel.org/r/20251013154441.1000875-1-superm1@kernel.org