linux-kernel - Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf787bfa-2bf1-44bc-be46-fa4115319bd0@suse.de>
Date: Mon, 13 Oct 2025 09:04:27 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Mario Limonciello <superm1@...nel.org>, Eric Biggers <ebiggers@...nel.org>
Cc: David Airlie <airlied@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
 Daniel Dadap <ddadap@...dia.com>
Subject: Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware_default() with a
 screen info check

Hi Mario,

thanks for handling this report quickly.

Am 12.10.25 um 21:06 schrieb Mario Limonciello:
[...]
>> I don't have CONFIG_SCREEN_INFO enabled, so the commit changed
>> vga_is_firmware_default() to always return false.
>
> Thanks, that definitely explains it.
>
>>
>> If DRM_AMDGPU depends on SCREEN_INFO now, it needs to select it.
>>
>> - Eric
>
> Well the question now is which driver should actually select it.
>
> Although it manifested for you in amdgpu, I don't think this is going 
> to be an amdgpu unique issue.
>
> Maybe this:
>
> diff --git a/drivers/video/fbdev/core/Kconfig 
> b/drivers/video/fbdev/core/Kconfig
> index 006638eefa41..ce2544924b0e 100644
> --- a/drivers/video/fbdev/core/Kconfig
> +++ b/drivers/video/fbdev/core/Kconfig
> @@ -5,6 +5,7 @@
>
>  config FB_CORE
>         select VIDEO
> +       select SCREEN_INFO

Let's select it from CONFIG_VGA_ARB. This will restore the old behavior 
for x86. The else branch for CONFIG_SCREEN_INFO can then go away.

Best regards
Thomas

> tristate
>
>  config FB_NOTIFY

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)