linux-kernel - Re: [PATCH net-next 1/6] tools: ynl-gen: bitshift the flag values in the generated code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3835375-6eea-467f-8488-fff62ce4262b@intel.com>
Date: Mon, 13 Oct 2025 16:07:22 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Alexei Starovoitov <ast@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>, Daniel Borkmann
	<daniel@...earbox.net>, Daniel Zahka <daniel.zahka@...il.com>, Donald Hunter
	<donald.hunter@...il.com>, Jesper Dangaard Brouer <hawk@...nel.org>, "Jiri
 Pirko" <jiri@...nulli.us>, Joe Damato <jdamato@...tly.com>, John Fastabend
	<john.fastabend@...il.com>, Jonathan Corbet <corbet@....net>, Simon Horman
	<horms@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Toke Høiland-Jørgensen <toke@...hat.com>, "Vadim
 Fedorenko" <vadim.fedorenko@...ux.dev>, Willem de Bruijn
	<willemb@...gle.com>, <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/6] tools: ynl-gen: bitshift the flag values in
 the generated code



On 10/13/2025 9:49 AM, Asbjørn Sloth Tønnesen wrote:
> Instead of pre-computing the flag values within the code generator,
> then move the bitshift operation into the generated code.
> 
> This IMHO makes the generated code read more like handwritten code.
> 
> No functional changes.
> 

Could we use BIT() here? or is that not available within uAPI headers?

Thanks,
Jake


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)