linux-kernel - Re: [PATCH net-next 0/6] tools: ynl-gen: generate flags better

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <611a6e2e-c22a-48dd-8450-f79005771568@intel.com>
Date: Mon, 13 Oct 2025 16:10:41 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Alexei Starovoitov <ast@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>, Daniel Borkmann
	<daniel@...earbox.net>, Daniel Zahka <daniel.zahka@...il.com>, Donald Hunter
	<donald.hunter@...il.com>, Jesper Dangaard Brouer <hawk@...nel.org>, "Jiri
 Pirko" <jiri@...nulli.us>, Joe Damato <jdamato@...tly.com>, John Fastabend
	<john.fastabend@...il.com>, Jonathan Corbet <corbet@....net>, Simon Horman
	<horms@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Toke Høiland-Jørgensen <toke@...hat.com>, "Vadim
 Fedorenko" <vadim.fedorenko@...ux.dev>, Willem de Bruijn
	<willemb@...gle.com>, <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 0/6] tools: ynl-gen: generate flags better



On 10/13/2025 9:49 AM, Asbjørn Sloth Tønnesen wrote:
> This series focusses on increasing the quality of
> the C code generated by ynl-gen for flags.
> 
> NB: I included a note in patch 6, on usage of the private
> NETDEV_XDP_ACT_MASK in user-space.
> 

Everything here is an improvement over the existing output. I would like
if we could use "BIT(N)" instead of "1U << N", but I think its better
than the current pre-computed values that you have to parse as bit values.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Asbjørn Sloth Tønnesen (6):
>   tools: ynl-gen: bitshift the flag values in the generated code
>   tools: ynl-gen: refactor render-max enum generation
>   tools: ynl-gen: use uapi mask definition in NLA_POLICY_MASK
>   tools: ynl-gen: add generic p_wrap() helper
>   tools: ynl-gen: construct bitflag masks in generated headers
>   tools: ynl-gen: allow custom naming of render-max definitions
> 
>  Documentation/netlink/genetlink-c.yaml        |  3 +
>  Documentation/netlink/genetlink-legacy.yaml   |  3 +
>  .../userspace-api/netlink/c-code-gen.rst      |  7 +-
>  include/uapi/linux/dpll.h                     |  6 +-
>  .../uapi/linux/ethtool_netlink_generated.h    | 20 ++---
>  include/uapi/linux/netdev.h                   | 34 ++++----
>  net/psp/psp-nl-gen.h                          |  4 +-
>  tools/include/uapi/linux/netdev.h             | 34 ++++----
>  tools/net/ynl/pyynl/lib/nlspec.py             |  7 +-
>  tools/net/ynl/pyynl/ynl_gen_c.py              | 79 +++++++++++--------
>  10 files changed, 117 insertions(+), 80 deletions(-)
> 



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)