linux-kernel - Re: [PATCH v5 02/10] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <387c707e-613d-433b-a76d-16ef10dabc59@kernel.org>
Date: Tue, 14 Oct 2025 01:50:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wesley Cheng <wesley.cheng@....qualcomm.com>, krzk+dt@...nel.org,
 conor+dt@...nel.org, konrad.dybcio@....qualcomm.com,
 dmitry.baryshkov@....qualcomm.com, kishon@...nel.org, vkoul@...nel.org,
 gregkh@...uxfoundation.org, robh@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
 linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 02/10] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB
 UNI PHY compatible

On 14/10/2025 01:46, Wesley Cheng wrote:
>>>>     "#clock-cells":
>>>>       const: 0
>>>> @@ -157,6 +160,25 @@ allOf:
>>>>           compatible:
>>>>             contains:
>>>>               enum:
>>>> +              - qcom,glymur-qmp-usb3-uni-phy
>>>> +    then:
>>>> +      properties:
>>>> +        clocks:
>>>
>>> Missing minItems.
>>>
>>
>> Hi Krzysztof,
>>
>> Won't the minItems be inherited by the base definition?
>>
> 
> Ah...are you saying to define minItems to 5 as well, since we need to 
> have all 5 clocks handles defined to work?


You need the minItems constraint as well, to define the dimension
accurately.

> 
> Thanks
> Wesley Cheng
> 
>>>> +          maxItems: 5
>>>> +        clock-names:
>>>> +          items:
>>>> +            - const: aux
>>>> +            - const: clkref
>>>> +            - const: ref
>>>
>>> What is the difference between these two? Which block INPUTs
>>> (important!) they represent?
>>>
>>
>> clkref is the TCSR reference clock switch, and the ref is the actual CXO 
>> handle.


Then this should be named somehow differently. CXO is clock. Reference
clock is clock... To me it feels like you are describing the same clock,
just missing some gate in TCSR. But in case these are not the same
clocks, you need to name it accurately.


Best regards,
Krzysztof