linux-kernel - Re: [PATCH v2 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <288eff27-ac0c-4e7f-a4cf-cc6169c88f3b@kernel.org>
Date: Mon, 13 Oct 2025 07:41:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@...era.com>,
 Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>, Vinod Koul
 <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>,
 "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
 <dmaengine@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Niravkumar L Rabara <niravkumar.l.rabara@...el.com>,
 "open list:CADENCE NAND DRIVER" <linux-mtd@...ts.infradead.org>,
 Dinh Nguyen <dinguyen@...nel.org>,
 Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property

On 13/10/2025 07:17, Khairul Anuar Romli wrote:
> Agilex5 uses the cdns,hp-nfc binding for the nand-controller node.

That's redundant.

> To support IOMMU functionality, an iommus property needs to be added to the cdns,hp-nfc.yaml binding file.

As well... so just say there is IOMMU used by this <here goes device name>.

> This ensures the device tree binding correctly describes the IOMMU association for the NAND controller.

Redundant. Don't explain us how DT works. We all know. Explain what we
do not know - your hardware. I already ASKED FOR THAT.

Also, completely broken wrapping. Please read submitting patches before
you post next version.

Best regards,
Krzysztof