linux-kernel - Re: [PATCH v3 1/2] scsi: sd: Add manage_restart device attribute to scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOyuLCEDJxJS76nN@ryzen>
Date: Mon, 13 Oct 2025 09:45:48 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Markus Probst <markus.probst@...teo.de>
Cc: Damien Le Moal <dlemoal@...nel.org>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-ide@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] scsi: sd: Add manage_restart device attribute to
 scsi_disk

On Fri, Oct 10, 2025 at 10:38:34PM +0000, Markus Probst wrote:
> In addition to the already existing manage_shutdown,
> manage_system_start_stop and manage_runtime_start_stop device
> scsi_disk attributes, add manage_restart, which allows the high-level
> device driver (sd) to manage the device power state for SYSTEM_RESTART if set to 1.

The commit message explains what is done, but does not answer the question:
"why?"

I can read patch 2/2 and understand why, but considering that this is a patch
for SCSI and not ATA, I think that you need to provide some context here, so
that someone doing a git log drivers/scsi/ will actually have any idea of why
this was done.


Kind regards,
Niklas