linux-kernel - Re: [PATCH v1] tools/rtla: Remove unused function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP4=nvSou70FUBF=GTKUziBfV5tXFKLcwgyDwcLmyA4y0PdS9Q@mail.gmail.com>
Date: Mon, 13 Oct 2025 09:48:53 +0200
From: Tomas Glozar <tglozar@...hat.com>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Crystal Wood <crwood@...hat.com>, 
	John Kacur <jkacur@...hat.com>, linux-trace-kernel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] tools/rtla: Remove unused function declarations

ne 12. 10. 2025 v 9:13 odesílatel Costa Shulyupin
<costa.shul@...hat.com> napsal:
>
> Historically four function declarations remain orphaned or duplicated.
>

For future reference, it is helpful to include where exactly and why
those were removed, especially considering that three of those four
were only removed in the most recent tag (6.18-rc1). For this case:

Commit 2f3172f9dd5 ("tools/rtla: Consolidate code between
osnoise/timerlat and hist/top") removed
{osnoise,timerlat}_{hist,top}_main() functions in favor of a common
function, run_tool(). Remove also their declarations to keep with
source clean, along with parse_cpu_list(), which was replaced by
parse_cpu_set() in commit 894c29c76b2b ("rtla: Change monitored_cpus
from char * to cpu_set_t").

> Remove them to keep the source clean.
>
> Signed-off-by: Costa Shulyupin <costa.shul@...hat.com>
> ---

Tomas