linux-kernel - RE: [PATCH 1/4] leds: Add Virtual Color LED Group driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DS0PR84MB374668EBA934375770E4A6CA9FEAA@DS0PR84MB3746.NAMPRD84.PROD.OUTLOOK.COM>
Date: Mon, 13 Oct 2025 00:24:08 +0000
From: Jonathan Brophy <professor_jonny@...mail.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Jonathan Brophy
	<professorjonny98@...il.com>, lee Jones <lee@...nel.org>, Pavel Machek
	<pavel@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Radoslav Tsvetkov
	<rtsvetkov@...dotech.eu>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>
Subject: RE: [PATCH 1/4] leds: Add Virtual Color LED Group driver

On FRI, 10 October 2025, Krzysztof Kozlowski wrote:


>> +	if (!ret) {
>> +		vled->blink_delay_on = blink_interval;
>> +		vled->blink_delay_off = blink_interval;
>> +	}
>> +
>> +	phandle_count = fwnode_property_count_u32(child_fwnode, "leds");
>
>
>No, don't mix OF and fwnode.

Thanks for the guidance I am working my way through the List if fixes and will offer a new patch set when complete.

Just one question is there a preference to use Device Tree (OF) functions or FWnode functions?
It is my under standing FWnode is newer and  more universal.

 Eg:
 phandle_count = of_property_count_elems_of_size(child, "leds", sizeof(u32));

Regards
Jonathan Brophy