linux-kernel - Re: [PATCH v1 3/6] iommu/exynos-iommu: Set release_domain to exynos_identity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1d3661d-26ba-49ae-a124-dc5233c9107d@samsung.com>
Date: Mon, 13 Oct 2025 10:51:57 +0200
From: Marek Szyprowski <m.szyprowski@...sung.com>
To: Nicolin Chen <nicolinc@...dia.com>, joro@...tes.org, jgg@...dia.com,
	kevin.tian@...el.com
Cc: suravee.suthikulpanit@....com, will@...nel.org, robin.murphy@....com,
	sven@...nel.org, j@...nau.net, robin.clark@....qualcomm.com,
	krzk@...nel.org, dwmw2@...radead.org, baolu.lu@...ux.intel.com,
	yong.wu@...iatek.com, matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com, tjeznach@...osinc.com,
	pjw@...nel.org, palmer@...belt.com, aou@...s.berkeley.edu, heiko@...ech.de,
	schnelle@...ux.ibm.com, mjrosato@...ux.ibm.com, orsonzhai@...il.com,
	baolin.wang@...ux.alibaba.com, wens@...e.org, jernej.skrabec@...il.com,
	samuel@...lland.org, thierry.reding@...il.com, jonathanh@...dia.com,
	jean-philippe@...aro.org, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	linux-riscv@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
	linux-s390@...r.kernel.org, linux-sunxi@...ts.linux.dev,
	linux-tegra@...r.kernel.org, virtualization@...ts.linux.dev,
	patches@...ts.linux.dev
Subject: Re: [PATCH v1 3/6] iommu/exynos-iommu: Set release_domain to
 exynos_identity_domain

On 13.10.2025 01:57, Nicolin Chen wrote:
> Following a coming core change to pass in the old domain pointer into the
> attach_dev op and its callbacks, exynos_iommu_identity_attach() will need
> this new argument too, which the release_device op doesn't provide.
>
> Instead, the core provides a release_domain to attach to the device prior
> to invoking the release_device callback. Thus, simply use that.
>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
>   drivers/iommu/exynos-iommu.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index b6edd178fe25e..0857519ca7188 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -1429,8 +1429,6 @@ static void exynos_iommu_release_device(struct device *dev)
>   	struct exynos_iommu_owner *owner = dev_iommu_priv_get(dev);
>   	struct sysmmu_drvdata *data;
>   
> -	WARN_ON(exynos_iommu_identity_attach(&exynos_identity_domain, dev));
> -
>   	list_for_each_entry(data, &owner->controllers, owner_node)
>   		device_link_del(data->link);
>   }
> @@ -1476,6 +1474,7 @@ static int exynos_iommu_of_xlate(struct device *dev,
>   
>   static const struct iommu_ops exynos_iommu_ops = {
>   	.identity_domain = &exynos_identity_domain,
> +	.release_domain = &exynos_identity_domain,
>   	.domain_alloc_paging = exynos_iommu_domain_alloc_paging,
>   	.device_group = generic_device_group,
>   	.probe_device = exynos_iommu_probe_device,

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland