linux-kernel - Re: [PATCH v1 6/6] iommu: Pass in old domain to attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO/bU6IFUBpo2iz/@Asurada-Nvidia>
Date: Wed, 15 Oct 2025 10:35:15 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: <joro@...tes.org>, <jgg@...dia.com>, <kevin.tian@...el.com>
CC: <suravee.suthikulpanit@....com>, <will@...nel.org>,
	<robin.murphy@....com>, <sven@...nel.org>, <j@...nau.net>,
	<robin.clark@....qualcomm.com>, <m.szyprowski@...sung.com>,
	<krzk@...nel.org>, <dwmw2@...radead.org>, <baolu.lu@...ux.intel.com>,
	<yong.wu@...iatek.com>, <matthias.bgg@...il.com>,
	<angelogioacchino.delregno@...labora.com>, <tjeznach@...osinc.com>,
	<pjw@...nel.org>, <palmer@...belt.com>, <aou@...s.berkeley.edu>,
	<heiko@...ech.de>, <schnelle@...ux.ibm.com>, <mjrosato@...ux.ibm.com>,
	<orsonzhai@...il.com>, <baolin.wang@...ux.alibaba.com>, <wens@...e.org>,
	<jernej.skrabec@...il.com>, <samuel@...lland.org>,
	<thierry.reding@...il.com>, <jonathanh@...dia.com>,
	<jean-philippe@...aro.org>, <iommu@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <asahi@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
	<linux-riscv@...ts.infradead.org>, <linux-rockchip@...ts.infradead.org>,
	<linux-s390@...r.kernel.org>, <linux-sunxi@...ts.linux.dev>,
	<linux-tegra@...r.kernel.org>, <virtualization@...ts.linux.dev>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v1 6/6] iommu: Pass in old domain to attach_dev callback
 functions

On Sun, Oct 12, 2025 at 04:57:42PM -0700, Nicolin Chen wrote:
> diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
> index aa576736d60ba..366e47978ac07 100644
> --- a/drivers/iommu/s390-iommu.c
> +++ b/drivers/iommu/s390-iommu.c
> @@ -670,7 +670,8 @@ int zpci_iommu_register_ioat(struct zpci_dev *zdev, u8 *status)
>  }
>  
>  static int blocking_domain_attach_device(struct iommu_domain *domain,
> -					 struct device *dev)
> +					 struct device *dev,
> +					 struct iommu_domain *old)
>  {
>  	struct zpci_dev *zdev = to_zpci_dev(dev);
>  	struct s390_domain *s390_domain;
> @@ -694,7 +695,8 @@ static int blocking_domain_attach_device(struct iommu_domain *domain,
>  }
>  
>  static int s390_iommu_attach_device(struct iommu_domain *domain,
> -				    struct device *dev)
> +				    struct device *dev,
> +				    struct iommu_domain *old)
>  {
>  	struct s390_domain *s390_domain = to_s390_domain(domain);
>  	struct zpci_dev *zdev = to_zpci_dev(dev);
> @@ -1131,7 +1133,8 @@ static int __init s390_iommu_init(void)
>  subsys_initcall(s390_iommu_init);
>  
>  static int s390_attach_dev_identity(struct iommu_domain *domain,
> -				    struct device *dev)
> +				    struct device *dev,
> +				    struct iommu_domain *old)
>  {
>  	struct zpci_dev *zdev = to_zpci_dev(dev);
>  	u8 status;

kernel test robot complains a build break..

Both s390_iommu_attach_device and s390_attach_dev_identity calls
the updated blocking_domain_attach_device function but are not
updated.

I will fix and send v2.

Thanks
Nicolin