linux-kernel - Re: [PATCH v1] driver: gpio-bt8xx: use generic PCI PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Me2ABQUXVeHyfsDR-etyT9mdX-kqxfQDnh3msfZiS6ccQ@mail.gmail.com>
Date: Mon, 13 Oct 2025 11:41:43 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Vaibhav Gupta <vaibhavgupta40@...il.com>
Cc: Michael Büsch <mb@...s.ch>, 
	kernel test robot <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev, 
	Bjorn Helgaas <helgaas@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] driver: gpio-bt8xx: use generic PCI PM

On Sat, Oct 11, 2025 at 1:32 PM Vaibhav Gupta <vaibhavgupta40@...il.com> wrote:
>
> On Sat, Oct 11, 2025 at 12:26:12PM +0200, Michael Büsch wrote:
> > On Sat, 11 Oct 2025 09:43:54 +0800
> > kernel test robot <lkp@...el.com> wrote:
> >
> > > Hi Vaibhav,
> > >
> > > kernel test robot noticed the following build errors:
> >
> > >    drivers/gpio/gpio-bt8xx.c: In function 'bt8xxgpio_suspend':
> > > >> drivers/gpio/gpio-bt8xx.c:233:19: error: 'struct bt8xxgpio' has no member named 'saved_outen'
> > >      233 |                 bg->saved_outen = bgread(BT848_GPIO_OUT_EN);
> > >          |                   ^~
> >
> >
> > It looks like the
> > #ifdef CONFIG_PM
> > must be removed from struct bt8xxgpio definition.
> >
> > --
> > Michael Büsch
> > https://bues.ch/
>
> Hello Michael,
>
> Ah yes, this macro somehow got overlooked by me. I will send a v2.
> Thanks for the review!
>
> Regards,
> Vaibhav

While at it: the subject should be: "gpio: bt8xx: ..."

Bart