lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3ed12beb-c054-4cd7-8938-64b899261887@lucifer.local>
Date: Mon, 13 Oct 2025 11:52:52 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Fushuai Wang <wangfushuai@...du.com>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, david@...hat.com,
        mhocko@...nel.org, zhengqi.arch@...edance.com, shakeel.butt@...ux.dev,
        axelrasmussen@...gle.com, yuanchu@...gle.com, weixugc@...gle.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN

On Mon, Oct 06, 2025 at 09:49:48AM +0800, Fushuai Wang wrote:
> The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
> 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
> remove the redundant __GFP_NOWARN flag.
>
> Signed-off-by: Fushuai Wang <wangfushuai@...du.com>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b2fc8b626d3d..e7ecf3b608cf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1054,7 +1054,7 @@ static unsigned int demote_folio_list(struct list_head *demote_folios,
>  		 * When this happens, 'page' will likely just be discarded
>  		 * instead of migrated.
>  		 */
> -		.gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN |
> +		.gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
>  			__GFP_NOMEMALLOC | GFP_NOWAIT,
>  		.nid = target_nid,
>  		.nmask = &allowed_mask,
> --
> 2.36.1
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ