[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d062e8c8-fe8d-40a8-bbdf-0a8483c23b03@amd.com>
Date: Mon, 13 Oct 2025 16:21:47 +0530
From: Sairaj Kodilkar <sarunkod@....com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@....com>, <jgg@...dia.com>,
<nicolinc@...dia.com>
CC: <linux-kernel@...r.kernel.org>, <robin.murphy@....com>, <will@...nel.org>,
<joro@...tes.org>, <kevin.tian@...el.com>, <jsnitsel@...hat.com>,
<vasant.hegde@....com>, <iommu@...ts.linux.dev>, <santosh.shukla@....com>,
<sairaj.arunkodilkar@....com>, <jon.grimm@....com>,
<prashanthpra@...gle.com>, <wvw@...gle.com>, <wnliu@...gle.com>,
<gptran@...gle.com>, <kpsingh@...gle.com>, <joao.m.martins@...cle.com>,
<alejandro.j.jimenez@...cle.com>
Subject: Re: [PATCH v3 01/15] iommu/amd: Rename DEV_DOMID_MASK to
DTE_DOMID_MASK
On 10/10/2025 5:27 AM, Suravee Suthikulpanit wrote:
> Also change the define to use GENMASK_ULL instead.
> There is no functional change.
>
> Reviewed-by: Nicolin Chen <nicolinc@...dia.com>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> ---
> drivers/iommu/amd/amd_iommu_types.h | 2 +-
> drivers/iommu/amd/iommu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/amd/amd_iommu_types.h b/drivers/iommu/amd/amd_iommu_types.h
> index a698a2e7ce2a..556f1df32d53 100644
> --- a/drivers/iommu/amd/amd_iommu_types.h
> +++ b/drivers/iommu/amd/amd_iommu_types.h
> @@ -422,7 +422,7 @@
>
> #define DTE_FLAG_IOTLB BIT_ULL(32)
> #define DTE_FLAG_MASK (0x3ffULL << 32)
> -#define DEV_DOMID_MASK 0xffffULL
> +#define DTE_DOMID_MASK GENMASK_ULL(15, 0)
>
> #define DTE_GCR3_14_12 GENMASK_ULL(60, 58)
> #define DTE_GCR3_30_15 GENMASK_ULL(31, 16)
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index b57a6993179d..a9b17d31a969 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -2094,7 +2094,7 @@ static void set_dte_entry(struct amd_iommu *iommu,
> if (dev_data->ats_enabled)
> new.data[1] |= DTE_FLAG_IOTLB;
>
> - old_domid = READ_ONCE(dte->data[1]) & DEV_DOMID_MASK;
> + old_domid = READ_ONCE(dte->data[1]) & DTE_DOMID_MASK;
> new.data[1] |= domid;
>
> /*
Hi suravee
Please update the replace the usage of DEV_DOMID_MASK in
init.c:__copy_device_table as well
Thanks
Sairaj
Powered by blists - more mailing lists