linux-kernel - Re: [PATCH net] net: usb: rtl8150: Fix frame padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251013125043.0ae574e7.michal.pecio@gmail.com>
Date: Mon, 13 Oct 2025 12:50:43 +0200
From: Michal Pecio <michal.pecio@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Petko Manolov <petkan@...leusys.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, linux-usb@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: usb: rtl8150: Fix frame padding

On Mon, 13 Oct 2025 10:57:51 +0100, Simon Horman wrote:
> Hi Michal,
> 
> I think this should also increment a dropped counter.
> As this driver already uses dev->netdev->stats [*]
> I think that would be:
> 
> 		dev->netdev->stats.tx_dropped++;
>
> [*] I specifically mention this, for the record because,
>     new users are discouraged. But this driver is an existing user
>     so I think we are ok.

Thanks, makes sense, will do.

I will only drop "dev->" because it's superfluous - we already have
'netdev' here, which was used to obtain 'dev' in the first place.