[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aOzx-4PtIMAk-8Nl@horms.kernel.org>
Date: Mon, 13 Oct 2025 13:35:07 +0100
From: Simon Horman <horms@...nel.org>
To: Michal Pecio <michal.pecio@...il.com>
Cc: Petko Manolov <petkan@...leusys.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
linux-usb@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: usb: rtl8150: Fix frame padding
On Mon, Oct 13, 2025 at 12:50:43PM +0200, Michal Pecio wrote:
> On Mon, 13 Oct 2025 10:57:51 +0100, Simon Horman wrote:
> > Hi Michal,
> >
> > I think this should also increment a dropped counter.
> > As this driver already uses dev->netdev->stats [*]
> > I think that would be:
> >
> > dev->netdev->stats.tx_dropped++;
> >
> > [*] I specifically mention this, for the record because,
> > new users are discouraged. But this driver is an existing user
> > so I think we are ok.
>
> Thanks, makes sense, will do.
>
> I will only drop "dev->" because it's superfluous - we already have
> 'netdev' here, which was used to obtain 'dev' in the first place.
Sounds good, sorry for missing that detail.
Powered by blists - more mailing lists