[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <11a8783345566d5ea6c696ecd007490289ba0b5f.camel@ti.com>
Date: Mon, 13 Oct 2025 16:43:19 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Anand Moon <linux.amoon@...il.com>
CC: Vignesh Raghavendra <vigneshr@...com>,
Lorenzo Pieralisi
<lpieralisi@...nel.org>,
Krzysztof WilczyĆski
<kwilczynski@...nel.org>,
Manivannan Sadhasivam <mani@...nel.org>,
"Rob
Herring" <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
"open
list:PCI DRIVER FOR TI DRA7XX/J721E" <linux-omap@...r.kernel.org>,
"open
list:PCI DRIVER FOR TI DRA7XX/J721E" <linux-pci@...r.kernel.org>,
"moderated
list:PCI DRIVER FOR TI DRA7XX/J721E" <linux-arm-kernel@...ts.infradead.org>,
open list <linux-kernel@...r.kernel.org>,
Siddharth Vadapalli
<s-vadapalli@...com>
Subject: Re: [RFC v1 1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to
get the clock
On Mon, 2025-10-13 at 15:47 +0530, Anand Moon wrote:
> Use devm_clk_get_optional_enabled() helper instead of calling
> devm_clk_get_optional() and then clk_prepare_enable(). It simplifies
> the error handling and makes the code more compact. This changes removes
> the unnecessary clk variable and assigns the result of the
> devm_clk_get_optional_enabled() call directly to pcie->refclk.
> This makes the code more concise and readable without changing the
> behavior.
>
> Cc: Siddharth Vadapalli <s-vadapalli@...com>
> Signed-off-by: Anand Moon <linux.amoon@...il.com>
> ---
> drivers/pci/controller/cadence/pci-j721e.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index 5bc5ab20aa6d..d6bbd04c615b 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -479,7 +479,6 @@ static int j721e_pcie_probe(struct platform_device *pdev)
> struct cdns_pcie_ep *ep = NULL;
> struct gpio_desc *gpiod;
> void __iomem *base;
> - struct clk *clk;
> u32 num_lanes;
> u32 mode;
> int ret;
> @@ -603,18 +602,11 @@ static int j721e_pcie_probe(struct platform_device *pdev)
> goto err_get_sync;
> }
>
> - clk = devm_clk_get_optional(dev, "pcie_refclk");
> - if (IS_ERR(clk)) {
> - ret = dev_err_probe(dev, PTR_ERR(clk), "failed to get pcie_refclk\n");
> - goto err_pcie_setup;
> - }
> -
> - ret = clk_prepare_enable(clk);
> - if (ret) {
> + pcie->refclk = devm_clk_get_optional_enabled(dev, "pcie_refclk");
> + if (IS_ERR(pcie->refclk)) {
> dev_err_probe(dev, ret, "failed to enable pcie_refclk\n");
> goto err_pcie_setup;
'err_pcie_setup' returns 'ret' which isn't being updated above.
Maybe add:
ret = pcie->refclk;
above dev_err_probe(...
> }
> - pcie->refclk = clk;
>
> /*
> * Section 2.2 of the PCI Express Card Electromechanical
Regards,
Siddharth.
Powered by blists - more mailing lists