linux-kernel - Re: [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c0f63162783f6eaa811901dbff9fbb4fe52c107.camel@ti.com>
Date: Mon, 13 Oct 2025 16:52:38 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Anand Moon <linux.amoon@...il.com>
CC: Vignesh Raghavendra <vigneshr@...com>,
        Lorenzo Pieralisi
	<lpieralisi@...nel.org>,
        Krzysztof Wilczyński
	<kwilczynski@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
        "open
 list:PCI DRIVER FOR TI DRA7XX/J721E" <linux-omap@...r.kernel.org>,
        "open
 list:PCI DRIVER FOR TI DRA7XX/J721E" <linux-pci@...r.kernel.org>,
        "moderated
 list:PCI DRIVER FOR TI DRA7XX/J721E" <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        Siddharth Vadapalli
	<s-vadapalli@...com>
Subject: Re: [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and
 drop local variable

On Mon, 2025-10-13 at 15:47 +0530, Anand Moon wrote:
> Change removes the unnecessary local gpiod variable and assigns the result
> of the devm_gpiod_get_optional() call directly to pcie->reset_gpio.
> This makes the code more concise and readable without changing the
> behavior.
> 
> Cc: Siddharth Vadapalli <s-vadapalli@...com>
> Signed-off-by: Anand Moon <linux.amoon@...il.com>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>

> ---
>  drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

[TRIMMED]

I have also tested the series (despite my feedback on the first patch).
Logs:
https://gist.github.com/Siddharth-Vadapalli-at-TI/ca82a16e15a892b3349396be17b37643

Please address the feedback on the first patch.

Regards,
Siddharth.