linux-kernel - Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08b4c0a0-cc59-4640-94ff-2d243c558a67@sirena.org.uk>
Date: Tue, 14 Oct 2025 14:11:47 +0100
From: Mark Brown <broonie@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Joan-Na-adi <joan.na.devcode@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, Joan Na <joan.na@...log.com>
Subject: Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator
 binding

On Tue, Oct 14, 2025 at 10:14:15AM +0200, Krzysztof Kozlowski wrote:
> On 14/10/2025 07:31, Joan-Na-adi wrote:

> > +  maxim,en-mode:
> > +    description: |
> > +      Enable mode configuration.
> > +      "push-button"  - Push button
> > +      "slide-switch" - Slide switch
> > +      "logic" - Logic mode

> You just repeat the name in the description. Say something useful.

Do you have concrete suggestions there?  I can see dropping the
descriptions entirely but otherwise I'm not sure there's much to
usefully add.

> > +  maxim,latency-mode:
> > +    description: |
> > +      Latency mode for voltage transition:
> > +      "high" - High latency (100μs)
> > +      "low"  - Low latency (10μs)

> So use values 100 or 10, and proper type (-us)

Without knowing the device specifics at all I rather suspect those
numbers are more ballparks than specifics.

> > +  maxim,dvs-slew-rate-mv-per-us:

> ... like here.

> > +    description: |
> > +      Dynamic rising slew rate for output voltage transitions, in mV/μs.

> Except you said mv/us, not us. Confusing.

That's what I'd expect for a slew rate?  It's the speed with which the
device ramps between voltages during voltage transitions, mV/us is a
perfectly normal unit for that.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)