linux-kernel - Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <176045970397.4162063.2449885497355673633.robh@kernel.org>
Date: Tue, 14 Oct 2025 11:35:16 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Joan-Na-adi <joan.na.devcode@...il.com>
Cc: Joan Na <joan.na@...log.com>, Mark Brown <broonie@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>, 
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator
 binding


On Tue, 14 Oct 2025 14:31:42 +0900, Joan-Na-adi wrote:
> From: Joan Na <joan.na@...log.com>
> 
> Add device tree binding YAML schema for the Maxim MAX77675 PMIC regulator.
> This defines the node properties and supported regulator names for use
> in device tree sources.
> 
> Fixed:
> - Missing explanation of `maxim,fps-slot` default value
> - Updated DT binding enums to use string values (e.g., "low", "high") instead of integers
> - Converted several binary properties to boolean type
> - Renamed time-based properties to use standard unit suffixes (e.g., "-sec", "-us")
> - Added default values for properties
> 
> Signed-off-by: Joan Na <joan.na@...log.com>
> ---
>  .../bindings/regulator/maxim,max77675.yaml    | 205 ++++++++++++++++++
>  1 file changed, 205 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77675.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:36:12: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:36:27: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:36:43: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:37:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:45:12: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:45:20: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:46:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:12: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:19: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:27: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:34: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:59:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:25: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:34: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:43: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:52: [error] string value is redundantly quoted with any quotes (quoted-strings)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251014053142.15835-4-joan.na@analog.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.