linux-kernel - Re: [PATCH 3/8] firmware: imx: scu-irq: Init workqueue before request mbox channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO5yaknwKGftsGxC@lizhi-Precision-Tower-5810>
Date: Tue, 14 Oct 2025 11:55:22 -0400
From: Frank Li <Frank.li@....com>
To: Peng Fan <peng.fan@....com>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dong Aisheng <aisheng.dong@....com>, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] firmware: imx: scu-irq: Init workqueue before
 request mbox channel

On Tue, Oct 14, 2025 at 12:54:40PM +0800, Peng Fan wrote:
> With mailbox channel requested, there is possibility that interrupts may
> come in, so need to make sure the workqueue is initialized before
> the queue is scheduled by mailbox rx callback.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  drivers/firmware/imx/imx-scu-irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c
> index 1fbe4c3de5c1592bfcf2334a83776c25d5ca7a3f..a53ed2040c0cf7065474d681b2eb933a15877380 100644
> --- a/drivers/firmware/imx/imx-scu-irq.c
> +++ b/drivers/firmware/imx/imx-scu-irq.c
> @@ -214,6 +214,8 @@ int imx_scu_enable_general_irq_channel(struct device *dev)
>  	cl->dev = dev;
>  	cl->rx_callback = imx_scu_irq_callback;
>
> +	INIT_WORK(&imx_sc_irq_work, imx_scu_irq_work_handler);
> +
>  	/* SCU general IRQ uses general interrupt channel 3 */
>  	ch = mbox_request_channel_byname(cl, "gip3");
>  	if (IS_ERR(ch)) {
> @@ -223,8 +225,6 @@ int imx_scu_enable_general_irq_channel(struct device *dev)
>  		return ret;
>  	}
>
> -	INIT_WORK(&imx_sc_irq_work, imx_scu_irq_work_handler);
> -
>  	if (!of_parse_phandle_with_args(dev->of_node, "mboxes",
>  				       "#mbox-cells", 0, &spec)) {
>  		i = of_alias_get_id(spec.np, "mu");
>
> --
> 2.37.1
>